Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the usage of more types of Actors and possibly other Documents (e.g. Items) #40

Open
arcanistzed opened this issue Apr 2, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@arcanistzed
Copy link
Owner

arcanistzed commented Apr 2, 2022

Solution

Either:

  • Harder: add another check for the new allowed types and use seperate mapping fields:

OR

  • Easier: remove that check completely and the user must change the mapping if they want to switch from exporting characters to any of the other options.

// If this is not a player character sheet, return without adding the button
if (!["character", "PC", "Player"].includes(sheet.actor.type ?? sheet.actor.data.type)) return;

@arcanistzed arcanistzed added the enhancement New feature or request label Apr 2, 2022
@arcanistzed arcanistzed self-assigned this Apr 2, 2022
@arcanistzed arcanistzed added the good first issue Good for newcomers label Apr 2, 2022
@arcanistzed arcanistzed changed the title Export NPC Actors Allow the usage of more types of Actors and possibly other Documents (e.g. Items) Apr 2, 2022
@oOve
Copy link

oOve commented Aug 11, 2022

Just putting my vote on allowing export of NPC's (monsters) as well

@arcanistzed
Copy link
Owner Author

I'm working on a large refactor and it will be included in that. In the meantime, this issue describes the very small change required for this.

@gioppoluca
Copy link
Collaborator

NPC now working will also work on items in time.
At the moment items get exported, for 5e, in the extended mapping and PDF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants