New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ArchesFileReader.import_business_data() for readability #11401

Open

jacobtylerwalls opened this issue Aug 27, 2024 · 1 comment

Member

jacobtylerwalls commented Aug 27, 2024

At its maximum, there are 21 levels of indentation in this function. We should refactor to avoid so much indentation.

(The github preview below doesn't do it justice, so click through):

arches/arches/app/utils/data_management/resources/formats/archesfile.py

Lines 460 to 466 in c6b043a

    
           if ( 
        
               child_tile_cardinality 
        
               == "1" 
        
           ): 
        
               populated_child_nodegroups.append( 
        
                   prototype_tile.nodegroup_id 
        
               )

This comment was marked as resolved.

Sign in to view

archesproject deleted a comment

archesproject deleted a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment