-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor search filters #11477
Comments
Just to add to this, from a high level: the |
As part of the PR #10999 disucssion, the group identified that the search filter logic should be refactored, and the
es_mapping_modifier
hook be applied to all search filters, not just the search_term filter. Time constraints stopped these changes from targeting version 7.6.x so it was decided to target 8.0.x for these changes.Currently the
append_dsl
method does several things:es_mapping_modifier.add_search_filter
method if it is configuredsearch_query_object
It was determined that these 3 steps should be broken into separate methods within each search filter to allow individual parts of the logic to be overriden. Also, the
add_search_filter
call should be added to the remaining filters.High level tasks for this are:
es_mapping_modifier.add_search_filter
such that it has the conext from which it is being called (eg what filter type is calling it -term_filter
,time_filter
, etc)The PR should target version dev/8.0.x
The text was updated successfully, but these errors were encountered: