Skip to content

[Bug]: typo in building_materials.csv #3837

@yiqiaowang-arch

Description

@yiqiaowang-arch

Describe the bug

  1. in the scenario\outputs\data\solar-radiation folder, the building material definition csv file is named as buidling_materials.csv, instead of building_materials.csv.
  2. The docstrings for the method that locates this file, InputLocator.get_radiation_materials, states the output incorrectly as {building}_geometry.csv.
  3. The actual method that should return {building}_geometry.csv path, InputLocator.get_radiation_metadata, also has a typo in its docstrings. Instead of "geometry", the incorrectly written "geometrgy" is used.

code snippet from line 1329 to 1335 in inputlocator.py:

    def get_radiation_metadata(self, building):
        """scenario/outputs/data/solar-radiation/{building}_geometrgy.csv"""
        return os.path.join(self.get_solar_radiation_folder(), '%s_geometry.csv' % building)

    def get_radiation_materials(self):
        """scenario/outputs/data/solar-radiation/{building}_geometry.csv"""
        return os.path.join(self.get_solar_radiation_folder(), 'buidling_materials.csv')

Changing the first problem might cause some users to suffer from CEA being unable to find the "buidling_materials.csv" when opening an old scenario. Of course, simple manual rename of such file can solve the problem.

Steps to reproduce

There's no need to execute in order to identify the problem.

Expected behavior

All spellings should be corrected.

Operating System

Windows

OS Version

No response

CEA Version

4.0.24

Screenshots

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions