Fix some UI changes. #484
Open
Fix some UI changes. #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArConnect BETA 1.13.2
ArConnect 1.13.1
## [1.13.1](v1.13.0...v1.13.1) (2024-06-13) ### Bug Fixes * Update old ao token with new ([b4ba415](b4ba415))
ArConnect BETA 1.13.3
ArConnect 1.13.2
## [1.13.2](v1.13.1...v1.13.2) (2024-06-14) ### Bug Fixes * Add ao token transfer notice popup & disable send flow ([ff6247a](ff6247a)) * Prevent infinte AR balance fetch ([e4b1617](e4b1617))
ArConnect BETA 1.14.0
ArConnect 1.14.0
# [1.14.0](v1.13.2...v1.14.0) (2024-06-18) ### Bug Fixes * added auth popup for all sign data items ([2495424](2495424)) * bip39 usage issue ([c0a5097](c0a5097)) * fixed an issue where transactions was null if ao cache was undefined ([9601d75](9601d75)) * hard coded ao mirror ([305ab9b](305ab9b)) * Make sure wallet selector stays on top of currency selector ([cfbd68b](cfbd68b)) * Update correct transaction received type ([e2d91b5](e2d91b5)) * Update the font size on resize ([2a39605](2a39605)) ### Features * removed password requirements and allow users to bypass password change request ([00ffc24](00ffc24))
ArConnect BETA 1.14.1
ArConnect 1.14.1
## [1.14.1](v1.14.0...v1.14.1) (2024-06-18) ### Bug Fixes * ao - banner ([789b562](789b562)) * Remove try catch to return null on error ([2d66bce](2d66bce))
ArConnect BETA 1.14.2
ArConnect 1.14.2
## [1.14.2](v1.14.1...v1.14.2) (2024-06-21) ### Bug Fixes * Amount width for larger amounts ([14486c1](14486c1)) * Issue related to allowance ([1b8bc62](1b8bc62)) * Make quantity integer if its ao token transfer ([364a5b5](364a5b5)) * misc light mode fixes on send and transactions ([85cceb6](85cceb6)) * Resolve bigint error in currency formatting functions ([6f3c650](6f3c650)) * Show quantity without exponential notation ([e517243](e517243)) * Use correct ao link message url ([c3cee14](c3cee14))
ArConnect BETA 1.14.3
ArConnect 1.14.3
## [1.14.3](v1.14.2...v1.14.3) (2024-06-26) ### Bug Fixes * Update AO token balance mirror ([1f18c4f](1f18c4f))
ArConnect BETA 1.15.0
ArConnect 1.15.0
# [1.15.0](v1.14.3...v1.15.0) (2024-07-02) ### Bug Fixes * added ability to copy wallet address from wallet switcher ([7715d1f](7715d1f)) * addressed comments ([065cb7e](065cb7e)) * disabled token info if not transfer in sda auth ([7423625](7423625)) * Fetch token info to show ticker and correct amount ([15c9137](15c9137)) * removed type ([971edf9](971edf9)) * Update tooltip descriptions ([06ff99d](06ff99d)) * updated error messages in import wallet ([11294cc](11294cc)) * updated messages ([bcb69e5](bcb69e5)) * updated send page to get latest token state for balances ([eae2350](eae2350)) ### Features * added manual token refresh on token view pages ([95d0306](95d0306)) * initialized weekly alarm for ao token info, refactored ao token balance ([bf8bea7](bf8bea7))
…-sda fix: disabling allowance limit on signDataItem
ArConnect BETA 1.16.0
Adds CONTRIBUTING.md and updates README.md
…llowance-on-sda Revert "fix: disabling allowance limit on signDataItem"
updating signDataItem endpoints and allowance
ArConnect 1.16.0
# [1.16.0](v1.15.0...v1.16.0) (2024-07-09) ### Bug Fixes * Add correct back functions ([0f0a669](0f0a669)) * add SignMessageOptions to README ([e7eaf29](e7eaf29)) * Add spacer to contacts ([9355344](9355344)) * all settings border color ([c4db4ba](c4db4ba)) * decode url for quick app settings ([01ae303](01ae303)) * disabling allowance limit on signDataItem ([376b925](376b925)) * Endless spinner issue when loading AR balance on dashboard ([6e6505e](6e6505e)) * Hide expand view on expanded view ([0d2b56c](0d2b56c)) * refactor endpoints ([2a5b52a](2a5b52a)) * Return to wallets list after wallet deletion ([2bc3d5d](2bc3d5d)) * Show correct fiat amount for AR in transactions history ([afdc639](afdc639)) * typo ([da64fe0](da64fe0)) * Update checkbox ([c823490](c823490)) * Update contact hover color ([d818034](d818034)) * Update notifications settings checkbox ([cbe9134](cbe9134)) * Update search input background color ([49641a2](49641a2)) * Update settings search filter function ([af535a4](af535a4)) * updated pricing endpoint for dispatch ([a2bf901](a2bf901)) * very message broken link ([54f24e5](54f24e5)) ### Features * Add apps quick settings ([8b659eb](8b659eb)) * Add contacts quick settings ([66feb99](66feb99)) * Add notifications quick settings ([6b61889](6b61889)) * Add tokens quick settings ([272aab1](272aab1)) * Add wallets quick settings ([77de61a](77de61a)) * Auto import ao tokens to dashboard ([a3ee98f](a3ee98f)) * completed explore page ([cd51e1c](cd51e1c)) * wip explore page for ecosystem apps ([a29077e](a29077e))
ArConnect BETA 1.17.0
ArConnect BETA 1.17.1
ArConnect BETA 1.17.2
ArConnect 1.17.0
# [1.17.0](v1.16.0...v1.17.0) (2024-07-16) ### Bug Fixes * arc 427 delay error messaging on send screen ([e96cfce](e96cfce)) * arc-426 update messaging ([2042aa7](2042aa7)) * changes made for Permissions component ([989bb8b](989bb8b)) * check bits only after logged in ([c9f8c52](c9f8c52)) * confirm button stuck on disabeled ([ed8039c](ed8039c)) * enabled permissions component ([663b2a9](663b2a9)) * Make sure tab cannot be closed before wallet is created ([37f4a03](37f4a03)) * messages ([42df190](42df190)) * re-added title removed misc ([44d1643](44d1643)) * removed excess messaging ([52bf07e](52bf07e)) * removed placeholder misc fixes ([ad72c2c](ad72c2c)) * Update matches logic for password ([781325d](781325d)) * updated copy for permissions ([b8c91f2](b8c91f2)) * updated quick settings permissions titles ([0e02410](0e02410)) * Use wallet ref ([0968ff5](0968ff5)) ### Features * Add edit permissions screen ([4f3433c](4f3433c)) * add screen 1 permission ([7c4b4e5](7c4b4e5)) * **keystone:** support ao signing ([1c119d8](1c119d8)) * **keystone:** support sign ao transfer via api for dapps ([8bbcd6c](8bbcd6c)) * **keystone:** wait for transaction prepared for keystone ([4c8028d](4c8028d)) * **wallet:** add validation for key length during import ([ceb033d](ceb033d)) * **wallet:** add validation for key length during wallet generation ([d0deebc](d0deebc))
ArConnect BETA 1.18.0
ArConnect 1.18.0
## [1.17.1](v1.17.0...v1.17.1) (2024-07-21) ### Bug Fixes * added always allow toggle in quick settings ([3aa6c02](3aa6c02)) * added always ask option and functionality ([1a279db](1a279db)) * added functionality to ask every time ([40d5c5e](40d5c5e)) * cn messages.json ([76e1039](76e1039)) * messages ([d4be9bf](d4be9bf)) * typo ([abb4961](abb4961)) * updated allowance ([79283c1](79283c1)) * updated is address format util fn to check for 43 length ([8f5fe20](8f5fe20)) ### Reverts * Revert "Revert "feat: updated permissions screen"" ([36190f4](36190f4))
ArConnect BETA 1.18.1
fix: typo in apps
ArConnect 1.18.0
# [1.18.0](v1.17.1...v1.18.0) (2024-08-07) ### Bug Fixes * Add password input keydown event ([0372ed4](0372ed4)) * changed permission name ([32389ef](32389ef)) * move app link to end of app row ([82b74aa](82b74aa)) * typo in apps ([e90caa0](e90caa0)) * Update apps logo background for some apps ([5e7835c](5e7835c)) ### Features * adds token balances endpoint ([09bc3b9](09bc3b9))
Fixes icon for wire transfer
ArConnect 1.18.1
## [1.18.1](v1.18.0...v1.18.1) (2024-08-09) ### Bug Fixes * icons for wire transfer ([3236d46](3236d46))
7i7o
requested changes
Oct 4, 2024
Comment on lines
+75
to
+78
| overflow: scroll; | ||
| background-color: ${(props) => | ||
| props.displayTheme === "light" ? "#ffffff" : "#191919"}; | ||
| border-radius: 10px 10px 0 0; |
There was a problem hiding this comment.
The white background mixed with the white in the CloseLayer makes this really hard to see in Light mode
Wdyt about maybe adding a subtle shadow or border to make it easier to see the slider covering the CloseLater/background items?
| position: relative; | ||
| height: 25px; | ||
| font-weight: 500; | ||
| font-size: 18px; | ||
| line-height: 25px; | ||
| color: ${(props) => | ||
| props.active ? props.theme.primaryText : props.theme.secondaryTextv2}; | ||
| color: ${(props) => (props.active ? "white" : props.theme.secondaryTextv2)}; |
There was a problem hiding this comment.
Suggested change
| color: ${(props) => (props.active ? "white" : props.theme.secondaryTextv2)}; | |
| color: ${(props) => (props.active ? props.theme.primaryText : props.theme.secondaryTextv2)}; |
Because in Light Mode this ends up being white on white
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<div>with<button>.Wallet selector with underlay:
Menu with underlay:
"Send" recipient selector drawer:
"Send" currency selector drawer (label to be updated):
"Buy" currency selector drawer (label to be updated):
"Buy" payment method selector (label to be updated):