fix: update dcast usage by making sure all data are preserved

* Return single value in `dcast.data.table()`. Required in `data.table` > 1.5. Fixes #94
Replace use of fun.aggregate argument of dcast with dummy variable in dataset for when x has duplicate values.
Method as described here: https://rdatatable.gitlab.io/data.table/reference/rowid.html
* doc: Clean up comments old code commented out.
* feat: improved version that keeps all of user's data.

fix #94
---------

Co-authored-by: Jan Marvin Garbuszus <[email protected]>
Co-authored-by: David Gohel <[email protected]>

Author: 3 people

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: mschart
 Type: Package
 Title: Chart Generation for 'Microsoft Word' and 'Microsoft PowerPoint' Documents
-Version: 0.4.0
+Version: 0.4.1.001
 Authors@R: c(
     person("David", "Gohel", role = c("aut", "cre"), 
       email = "[email protected]"),
@@ -31,6 +31,6 @@ Imports: stats, data.table,
  htmltools, utils
 URL: https://ardata-fr.github.io/officeverse/, https://ardata-fr.github.io/mschart/
 BugReports: https://github.com/ardata-fr/mschart/issues
-RoxygenNote: 7.2.2
+RoxygenNote: 7.3.1
 Roxygen: list(markdown = TRUE)
 Suggests: tinytest, doconv

NAMESPACE

@@ -35,6 +35,8 @@ importFrom(cellranger,as.range)
 importFrom(cellranger,cell_limits)
 importFrom(cellranger,ra_ref)
 importFrom(cellranger,to_string)
+importFrom(data.table,":=")
+importFrom(data.table,.N)
 importFrom(data.table,as.data.table)
 importFrom(data.table,dcast.data.table)
 importFrom(data.table,rbindlist)

NEWS.md

@@ -1,3 +1,9 @@
+# mschart 0.4.1
+
+## Issues
+
+* fix issue with dcast by making sure all data are preserved.
+
 # mschart 0.4.0
 
 ## New features

R/excel_series.R

@@ -57,17 +57,17 @@ transpose_data <- function(data, vars, group) {
 }
 
 
+#' @importFrom data.table := .N
 dcast_data <- function(data, x, y, group) {
   dataset <- as.data.table(data)
-  form_str <- sprintf("%s ~ %s", x, group)
+  dataset <- dataset[, c(".fake_id.") := list(seq_len(.N)), by = c(x, group)]
+  form_str <- sprintf("%s + .fake_id. ~ %s", x, group)
   out <- dcast.data.table(
     dataset,
     formula = as.formula(form_str),
-    fun.aggregate = function(x) {
-      x
-    },
     fill = NA, value.var = y
   )
+  out$.fake_id. <- NULL
   setDF(out)
   out
 }
@@ -96,9 +96,6 @@ transpose_series_bysplit <- function(x) {
 
 
 
-
-
-
 #' @importFrom stats as.formula
 #' @importFrom data.table as.data.table dcast.data.table setorderv setnames
 shape_as_series <- function(x) {