prisma-loader removed from repo?

[clemens]

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

• 1. The issue provides a reproduction available on Github, Stackblitz or CodeSandbox

  Make sure to fork this template and run yarn generate in the terminal.

  Please make sure the GraphQL Tools package versions under package.json matches yours.

• 2. A failing test has been provided
• 3. A local solution has been provided
• 4. A pull request is pending review

---

Describe the bug

It seems that the prisma-loader was removed from this repo in a commit that went straight to main, not via PR. This looks like an accident to me, since there's no indication anywhere that this package would be abandoned or anything similar and there's also no changelog entry to indicate intention.

To Reproduce Steps to reproduce the behavior:

ls packages/loaders | grep prisma doesn't show the package.

Expected behavior

ls packages/loaders | grep prisma does show the package.

Additional context

I came across this while trying to find out why prisma-loaders depends on the outdated graphql-request v6 (v7 has been out for more than a year), even though the repo seems to receive regular dependency updates. This is when I couldn't find it and started investigating.

[clemens]

@ardatan I thought I'd follow up and tag you directly – hope you don't mind…

[ardatan]

Sorry for the late response @clemens !
This package was intended to be used with an older versions of Prisma. And the newer versions of Prisma has a different approach to GraphQL integration. So we think this package is no longer needed and then we can deprecate and remove it.
Learn more about Prisma and GraphQL integration
Due to its old dependencies etc, it was hard to keep maintaining it with those old and unmaintained dependencies. But if you think it is still needed, maybe we can extract it into a new repository and leave the maintenance to the community.
Could you tell more about your use case?

[clemens]

Thanks for the response and for clarifying!

We're not actively using that package – only indirectly via @graphql-codegen/cli, which had it as a full-blown dependency until very recently (dotansimha/graphql-code-generator#10218). That, combined with the fact that you seem to have removed it directly from the codebase without a PR or changelog entry where I could understand the rationale that you just gave here in your comment, led me to just being confused about it: It's not the approach that I've seen other people take when deprecating a package – even from a monorepo.

Since it's apparently only 3 people who were confused by it (me and the 2 people who reacted to my post), I guess it's not that big of an issue. Still, maybe a better approach here would be to at least re-create the folder and put a README there with the same message that's now shown at https://www.npmjs.com/package/@graphql-tools/prisma-loader (that's new, right? I don't remember seeing it a couple of weeks ago when I filed this issue). Or just re-create it in its latest state with the same warning in the README.

Happy to submit a PR to do one or the other if you don't want to invest the time. Just let me know.

Thanks again!

[ardatan]

We don't want to keep its code in this repo. As I said earlier, it needs a maintenance like updating dependencies in order to avoid security vulnerability alerts etc. I think creating a new repo so anyone from the community who uses it still can help maintaining it seperately

[ardatan]

https://github.com/ardatan/graphql-tools-prisma-loader

[clemens]

Thanks, that's an excellent solution!