Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing method #196

Closed
jdavid54 opened this issue Oct 11, 2023 · 1 comment
Closed

Missing method #196

jdavid54 opened this issue Oct 11, 2023 · 1 comment
Assignees
@per1234
Labels
conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@jdavid54
Copy link

jdavid54 commented Oct 11, 2023 •
edited
Loading

The original method included method
String getFormattedDate(unsigned long secs = 0);
which then calls String getFormattedTime(unsigned long secs = 0);

Why does this version 3.2.1 exclude getFormattedDate and change to getFormattedTime() const ?

I have changed the 3 files (h, cpp, keywords.txt) and zip for a new library.
NTPClient-3.2.1_modified.zip
@per1234 per1234 self-assigned this Oct 12, 2023
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Oct 12, 2023
@per1234
Copy link
Contributor

per1234 commented Oct 12, 2023

Hi @jdavid54. There never was such a method in this library. If you saw one before you must have been using a different library or a unofficial modified version of the library.

There are several proposals for adding such a capability to the library:

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2023
@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@per1234 per1234

Labels
conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@per1234 @jdavid54