Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode visual flash #1

Open
arekouzounian opened this issue Jun 1, 2024 · 0 comments
Open

Dark Mode visual flash #1

arekouzounian opened this issue Jun 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@arekouzounian
Copy link
Owner

Dark mode is being handled by the footer component, which is the only client side component currently. Since it's a client side component, it gets to use the localStorage to check for dark mode, which lets the selection persist between refreshes.

Right now, whenever dark mode is selected, there is a visual flash on page load because the footer is loading last and setting the page theme to dark mode.

Maybe styles can be switched to have dark mode as default, but this would just result in the opposite error where the page would be dark before it updated.

@arekouzounian arekouzounian added the bug Something isn't working label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant