Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG-python/deployment] Duplicate labels in helm chart #5788

Open
CreMindES opened this issue Jan 21, 2025 · 1 comment
Open

[BUG-python/deployment] Duplicate labels in helm chart #5788

CreMindES opened this issue Jan 21, 2025 · 1 comment
Assignees

Comments

@CreMindES
Copy link

Describe the bug

The helm chart in examples has duplicate labels app.kubernetes.io/component: worker which breaks kustomize when wrapping the chart.

Stacktrace and code to create the bug

helm template .

...
# Source: argilla/templates/worker-deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: release-name-argilla-worker
  labels:
    helm.sh/chart: argilla-0.1.0
    app.kubernetes.io/component: worker
    app.kubernetes.io/version: "latest"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/component: worker
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/component: worker
      app.kubernetes.io/name: release-name-worker
      app.kubernetes.io/instance: release-name-worker
      app.kubernetes.io/component: worker
  template:
    metadata:
      labels:
        app.kubernetes.io/component: worker
        app.kubernetes.io/name: release-name-worker
        app.kubernetes.io/instance: release-name-worker
        app.kubernetes.io/component: worker
    spec:
...

Expected behavior

helm template .

# Source: argilla/templates/worker-deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: release-name-argilla-worker
  labels:
    helm.sh/chart: argilla-0.1.0
    app.kubernetes.io/component: worker
    app.kubernetes.io/version: "latest"
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/component: worker
      app.kubernetes.io/name: release-name-worker
      app.kubernetes.io/instance: release-name-worker
  template:
    metadata:
      labels:
        app.kubernetes.io/component: worker
        app.kubernetes.io/name: release-name-worker
        app.kubernetes.io/instance: release-name-worker
    spec:

Environment

  • Argilla Helm Chart 0.1.0
  • Helm v3.16.4
  • Kustomize 5.4.3

Additional context

No response

@davidberenstein1957
Copy link
Member

hi @CreMindES , thank you for this highlight. Could you help us out by creating a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants