Merge pull request #26 from argon-it/feat/ci-feedback-loop

feat: add CI feedback loop for agent code quality

Author: xfiive

.githooks/pre-commit

@@ -0,0 +1,86 @@
+#!/usr/bin/env bash
+#
+# Pre-commit hook for Seedfast CLI
+#
+# Enable by running: git config core.hooksPath .githooks
+#
+
+set -euo pipefail
+
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+NC='\033[0m' # No Color
+
+failed=0
+
+echo "Running pre-commit checks..."
+
+# 1. Check formatting on staged .go files only
+staged_go_files=$(git diff --cached --name-only --diff-filter=ACM -- '*.go' || true)
+if [ -n "$staged_go_files" ]; then
+    unformatted=""
+    for file in $staged_go_files; do
+        if [ -f "$file" ]; then
+            output=$(gofmt -l "$file" 2>/dev/null || true)
+            if [ -n "$output" ]; then
+                unformatted="$unformatted\n  $file"
+            fi
+        fi
+    done
+    if [ -n "$unformatted" ]; then
+        echo -e "${RED}FAIL${NC} go fmt: unformatted files detected:${unformatted}"
+        echo "  Run: gofmt -w . (or go fmt ./...)"
+        failed=1
+    else
+        echo -e "${GREEN}PASS${NC} go fmt"
+    fi
+else
+    echo -e "${GREEN}SKIP${NC} go fmt (no staged .go files)"
+fi
+
+# 2. go vet
+echo -n "Running go vet... "
+if ! go vet ./... 2>&1; then
+    echo -e "${RED}FAIL${NC} go vet"
+    failed=1
+else
+    echo -e "${GREEN}PASS${NC} go vet"
+fi
+
+# 3. Production build
+echo -n "Running go build... "
+if ! go build ./... 2>&1; then
+    echo -e "${RED}FAIL${NC} go build (production)"
+    failed=1
+else
+    echo -e "${GREEN}PASS${NC} go build (production)"
+fi
+
+# 4. Dev build
+echo -n "Running go build -tags dev... "
+if ! go build -tags dev ./... 2>&1; then
+    echo -e "${RED}FAIL${NC} go build -tags dev"
+    failed=1
+else
+    echo -e "${GREEN}PASS${NC} go build -tags dev"
+fi
+
+# 5. Check for staged docs/ files
+staged_docs=$(git diff --cached --name-only -- 'docs/' || true)
+if [ -n "$staged_docs" ]; then
+    echo -e "${RED}FAIL${NC} docs/ files staged for commit (internal docs, not for public repo):"
+    echo "$staged_docs" | sed 's/^/  /'
+    echo "  Unstage with: git reset HEAD docs/"
+    failed=1
+else
+    echo -e "${GREEN}PASS${NC} no docs/ files staged"
+fi
+
+if [ "$failed" -ne 0 ]; then
+    echo ""
+    echo -e "${RED}Pre-commit checks failed.${NC} Fix the issues above and try again."
+    exit 1
+fi
+
+echo ""
+echo -e "${GREEN}All pre-commit checks passed.${NC}"

.github/workflows/ci.yml

@@ -10,6 +10,24 @@ permissions:
   contents: write
 
 jobs:
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.25.1'
+          cache: true
+
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v6
+        with:
+          version: latest
+
   ci:
     name: CI
     runs-on: ubuntu-latest
@@ -59,5 +77,21 @@ jobs:
       - name: Vet
         run: go vet ./...
 
-      - name: Test
-        run: go test ./... -timeout 300s
+      - name: Test with coverage
+        run: go test -coverprofile=coverage.out -timeout 300s ./...
+
+      - name: Coverage summary
+        if: always()
+        run: |
+          if [ -f coverage.out ]; then
+            echo "### Coverage Summary"
+            go tool cover -func=coverage.out | tail -1
+          fi
+
+      - name: Upload coverage profile
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: coverage-profile
+          path: coverage.out
+          retention-days: 30

.golangci.yml

@@ -0,0 +1,20 @@
+run:
+  timeout: 3m
+  go: "1.24"
+
+linters:
+  enable:
+    - errcheck
+    - ineffassign
+    - staticcheck
+    - unused
+    - govet
+    - gofmt
+
+issues:
+  exclude-files:
+    - ".*\\.pb\\.go$"
+  exclude-rules:
+    - path: _test\.go
+      linters:
+        - errcheck

CLAUDE.md

@@ -63,16 +63,14 @@ The main Claude Code session acts as the team lead. It coordinates all work by s
 
 Sequential issue pipeline:
 
-1. **Coder** implements fix -> proactively notifies tester
-2. **Tester** designs test plan:
-   - Define precise expected behavior for each scenario (not "one of these outcomes is fine")
-   - Proactively consult KB manager for existing knowledge about how the feature should work
-   - Cover edge cases aggressively -- that's the whole point of a test plan
-   - Agree expected behavior with team lead before executing
-   - Never test log levels or implementation details -- only observable behavior
-   - Submit plan to team lead for approval -> execute after approval
-3. **KB manager** proactively updates knowledge base once testing passes
-4. Team proceeds to next issue
+1. **Coder** implements fix → proactively notifies tester
+2. **Tester** designs test plan → submits to team lead for approval → executes after approval
+3. **Test results:**
+   - **PASS** → KB manager updates docs → proceed to next issue
+   - **FAIL** → tester sends structured error report (see go-tester.md template) → coder
+4. **Coder** fixes based on structured report → notifies tester (retry from step 3)
+5. **Max 3 iterations** — if tests still fail after 3 coder→tester cycles, escalate to team lead
+6. **Team lead** decides: alternative approach, accept with known issues, or architectural change
 
 ### Key Team Rules