Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

Optional parameters are not optional in method signatures #3

Open
crenshaw-dev opened this issue Mar 11, 2020 · 0 comments
Open

Optional parameters are not optional in method signatures #3

crenshaw-dev opened this issue Mar 11, 2020 · 0 comments

Comments

@crenshaw-dev
Copy link

WorkflowServiceApi.listWorkflows, for example, requires all parameters even though all but namespace is optional.

This causes several issues:

  1. ugly code, with a bunch of parameters specified for every call
  2. duplication, with parameters specified in multiple places (unless the user abstracts them out)
  3. upgrade difficulty, because otherwise-insignificant method signature changes will break calls
  4. uncertain behavior, because without thoroughly investigating argo-server code, it's unclear what values are the correct defaults

I suspect this is either an OpenAPI-Generator bug or config issue. If I generate a scala client with OpenAPI-Generator's scala-akka plugin, the parameters are Options defaulted to None.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant