Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to update secrets #5

Open
dtaniwaki opened this issue Oct 2, 2019 · 0 comments
Open

Allow to update secrets #5

dtaniwaki opened this issue Oct 2, 2019 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@dtaniwaki
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I updated the slack URL after I tried several notifications with my old incoming webhook URL, but the operator didn't take new one until I delete the pod and let it restarted.

Describe the solution you'd like

We're caching the client once it gets created.

notifierMap[notifier.Name] = integration.NewSlackClient(client, namespace, notifier.Slack)

We need a mechanism to sync secrets and recreate slack clients.

Describe alternatives you've considered

Just delete the operator pod when a secret gets updated although it doesn't scale at all.

Additional context

N/A

@dtaniwaki dtaniwaki changed the title Allow to update secret Allow to update secrets Oct 2, 2019
@sarabala1979 sarabala1979 added the help wanted Extra attention is needed label Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants