Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make terminals for pods on workload clusters working on the control plane #129

Open
jannfis opened this issue Jul 13, 2024 · 0 comments
Open
Labels
design required Requires thorough design beforehand enhancement New feature or request
Milestone

Comments

@jannfis
Copy link
Collaborator

jannfis commented Jul 13, 2024

The Argo CD API server talks to a target Kubernetes API to stream the logs of a managed application's pod. This will not work in an agent based model. We need to figure out how we can support this use case with argocd-agent.

Similar to #128, some idea around this is having a Kubernetes API proxy for the Argo CD API server, which proxies pod log requests to the principal. If the appropriate agent is connected, it could be requested to stream the terminal connection to the principal, which in turn would send it via the Kubernetes API proxy to the Argo CD server. Not sure if that is feasible, though.

We need to think this through.

@jannfis jannfis added enhancement New feature or request design required Requires thorough design beforehand labels Jul 13, 2024
@jannfis jannfis added this to the v1.0.0 (GA) milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design required Requires thorough design beforehand enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant