feat: support periodic ping to principal for keeping connection alive #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparsai
requested review from
jannfis,
jgwest,
ishitasequeira and
chetan-rns
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
- Coverage 48.55% 48.29% -0.27%
==========================================
Files 73 73
Lines 6314 6349 +35
==========================================
Hits 3066 3066
- Misses 2983 3018 +35
Partials 265 265 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jayendra Parsai <[email protected]>
|
gRPC has support for configuring keepalives. Do you think we should use it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to introduce a configurable periodic ping event to keep connection alive between agent and principal. The agent will send an event to principal after given interval, principal will not process this event and just acknowledge it. By default it is disabled and to enable it devs need to set value of
agent-ping-intervalin startup script or set envAGENT_PING_INTERVALvariable.Fixes #171