Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default destination server override in spoke Application with option to disable #207

Open
mikeshng opened this issue Oct 23, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mikeshng
Copy link
Contributor

mikeshng commented Oct 23, 2024

Currently, when an Argo CD Application is created on a spoke cluster, there is no default behavior for setting the destination.server field to https://kubernetes.default.svc.

I propose adding a default behavior where the destination.server is automatically set to https://kubernetes.default.svc.

Additionally, an option should be provided to disable this defaulting behavior to enable more flexible deployment scenarios. Such as the fan-out model.

Reason:
The pull model is primarily designed for spoke clusters to reconcile their own state and perform in-cluster processing independently. When the destination.server is not explicitly set to the https://kubernetes.default.svc, it introduces the possibility of users picking any destinations. This can lead to inconsistencies and management complexity.

However, for experts and complex scenarios, this option should still be available. So a configuration should be provided to disable the default behavior (or enable the fan-out mode) as needed.

@mikeshng
Copy link
Contributor Author

/assign @mikeshng

@jannfis if you agree with this approach. I would like to hack at it. Thanks.

@jannfis jannfis added the enhancement New feature or request label Oct 23, 2024
@jannfis
Copy link
Collaborator

jannfis commented Oct 23, 2024

@mikeshng Thank you, appreciate your offer! I agree with the approach, feel free to proceed with the implementation :)

@jannfis jannfis added this to the v0.2.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants