Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish/Validate the jsonschema for the config.json #56

Open
leoluz opened this issue Sep 26, 2023 · 0 comments
Open

Publish/Validate the jsonschema for the config.json #56

leoluz opened this issue Sep 26, 2023 · 0 comments

Comments

@leoluz
Copy link
Collaborator

leoluz commented Sep 26, 2023

The metrics extension depends on a complex json object that should be added as a string field named as config.json in the configmap argocd-metrics-server-configmap. As today the expected json format isn't documented anywhere, it makes it hard for users to craft it correctly.

As part of this issue, we should publish the jsonschema based on the json struct defined in the Go code:

type O11yConfig struct {
	Prometheus *MetricsConfigProvider `json:"prometheus"`
	Wavefront  *MetricsConfigProvider `json:"wavefront"`
}

The same published jsonschema should be used to validate the config.json in the configmap during application bootstrap.

Suggested library that could be used to generate the jsonschema:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant