Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semver strategy is NOT working as the document claimed #556

Open
zywillc opened this issue Apr 17, 2023 · 0 comments · May be fixed by #552
Open

semver strategy is NOT working as the document claimed #556

zywillc opened this issue Apr 17, 2023 · 0 comments · May be fixed by #552
Labels
bug Something isn't working

Comments

@zywillc
Copy link

zywillc commented Apr 17, 2023

Describe the bug
current tags filtering behavior will skip semver constraint for prereleases versions (although they are valid semver versions) when there is no explicit constraint parsed from image tags (i.e. empty string) which is inconsistent with the document description.
https://github.com/argoproj-labs/argocd-image-updater/blob/master/pkg/image/version.go#L135-L147

some complex prerelease constraint rules are actually not supported untilsemver > 3.2.0

To Reproduce
Steps to reproduce the behavior:

Expected behavior
follow the truth about semver strategy behavior as the documented and constraint supporting *-0 for prerelease versions

Additional context
fix pr:
#552

Version
0.12.1

Logs
Please paste any relevant logs here
@zywillc zywillc added the bug Something isn't working label Apr 17, 2023
@chengfang chengfang linked a pull request Oct 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

default semver constraint for empty string zywillc/argocd-image-updater
1 participant
@zywillc