Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Working with Multi Source App #785

Closed
sashokbg opened this issue Jul 17, 2024 · 5 comments
Closed

Not Working with Multi Source App #785

sashokbg opened this issue Jul 17, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@sashokbg
Copy link

sashokbg commented Jul 17, 2024

Describe the bug
When using a multi source helm application as described here https://argo-cd.readthedocs.io/en/stable/user-guide/multiple_sources/
The image updater does not seem to work. Changing the digest of my docker image is not detected for some reason.

To Reproduce

Create a multi source application. Configure the annotations on your argocd app:
apiVersion: argoproj.io/v1alpha1
kind: Application
spec:
  sources:
  - repoURL: 'https://prometheus-community.github.io/helm-charts'
    chart: prometheus
    targetRevision: 15.7.1
    helm:
      valueFiles:
      - $values/charts/prometheus/values.yaml
  - repoURL: 'https://git.example.com/org/value-files.git'
    targetRevision: dev
    ref: values
    argocd-image-updater.argoproj.io/image-list:
    argocd-image-updater.argoproj.io/api.helm.image-name: 
    argocd-image-updater.argoproj.io/api.helm.image-tag: dev
    argocd-image-updater.argoproj.io/api.update-strategy: digest

Use crane to retag your tag:

crane tag gitlab-registry.mycompany.net/my-project/backend:commit-sha dev

Expected behavior
The image updater should update the image if the digest changes

Additional context
Add any other context about the problem here.

Version
Image Updater version v0.12.0 and ArgoCD v2.9.5

@sashokbg sashokbg added the bug Something isn't working label Jul 17, 2024
@sashokbg sashokbg changed the title Not Working withMulti Source App Not Working with Multi Source App Jul 17, 2024
@jannfis
Copy link
Contributor

jannfis commented Jul 17, 2024

Version
Image Updater version v0.12.0 and ArgoCD v2.9.5

There have been a couple of changes and fixes since v0.12.0, can you please update to the latest version and see if your issue still persist?

@mmueller-rs
Copy link

Hello,
I've got the same issue with a multi-source application on argocd-image-updater v0.14.0.

The application is of type "Kustomize". The same configuration with spec.source works, but as I'm planning to use multi-sources in the future, I've moved the configuration to spec.sources[0] and there argocd-image-updater fails with the following error:

level=warning msg="skipping app 'application-test' of type 'Directory' because it's not of supported source type" application=application-test

where "application-test" is the application's name.

Maybe this issue is related to #558 ?

Best,
Max

PS:
In case it's interesting, the annotations look like this:

  annotations:
    argocd-image-updater.argoproj.io/test.update-strategy: digest
    argocd-image-updater.argoproj.io/image-list: test=ghcr.io/mmueller-rs/test:staging

@gregkonush
Copy link

having the same issue where multi source application created from set is not getting updated even though it says so in logs.

@chengfang
Copy link
Collaborator

I tested with latest image-updater in master, with argo-cd stable version, and multi-source apps seem to work fine. I tried both kustomized- and helm-based multi-source app in https://github.com/chengfang/image-updater-examples . If you still seem problems, can you share a reproducible app or steps?

@sashokbg
Copy link
Author

Hello @chengfang problem seems to be solved with latest version. I think our devops team did not have the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants