Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Dumping App Conditions can contain sensitive information #390

Open
sidewinder12s opened this issue Mar 8, 2022 · 0 comments
Open

Dumping App Conditions can contain sensitive information #390

sidewinder12s opened this issue Mar 8, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@sidewinder12s
Copy link

Summary

One of our apps went into a degraded state and then dumped a ComparisonError and the RPC message of the error which contained sensitive information/credentials. It seems like a lot of conditions could dump data out of the condition output.

Diagnostics

It appears to be this section of the templates.

          {{range $index, $c := .app.status.conditions}}
          {{if not $index}},{{end}}
          {{if $index}},{{end}}
          {
            "title": "{{$c.type}}",
            "value": "See App",
            "short": true
          }
          {{end}}

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@sidewinder12s sidewinder12s added the bug Something isn't working label Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant