Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Should make argocd-notifications-secret to an optional argument #428

Open
kumo-rn5s opened this issue Sep 8, 2022 · 0 comments
Open

Should make argocd-notifications-secret to an optional argument #428

kumo-rn5s opened this issue Sep 8, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@kumo-rn5s
Copy link

kumo-rn5s commented Sep 8, 2022

Summary

For webhooks that do not use secrets(like discord),
the notification controller should not detect the existence of argocd-notifications-secret

Diagnostics

My environment:
EKS 1.22
Argocd v2.4.11+3d9e9f2
Argocd notifications v1.2.1

This is the log without argocd-notifications-secret applied

time="2022-09-08T14:01:23Z" level=info msg="Start processing" resource=argocd/app
time="2022-09-08T14:01:23Z" level=error msg="Failed to process: secret \"argocd-notifications-secret\" not found" resource=argocd/app

After adding a empty secret

apiVersion: v1
kind: Secret
metadata:
  name: argocd-notifications-secret
type: Opaque

The controller is available immediately

time="2022-09-08T14:01:23Z" level=info msg="Start processing" resource=argocd/app
time="2022-09-08T14:01:23Z" level=info msg="Processing skipped: sync status out of date" resource=argocd/app

I have just used argocd for a short time, so please correct me if my description is technically incorrect.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@kumo-rn5s kumo-rn5s added the bug Something isn't working label Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant