Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argocd-operator-controller-manager-service pod selector not unique to argo #1087

Open
fuerer opened this issue Nov 28, 2023 · 7 comments
Open

Comments

@fuerer
Copy link

fuerer commented Nov 28, 2023

Describe the bug
The service argocd-operator-controller-manager-service has the pod selector control-plane=controller-manager
In our OpenShift environment we have two additional operators (amq/otel) which have the same label on their operator pods.
With that the service points to the amq, argocd and otel pod.

To Reproduce
Steps to reproduce the behavior:

  1. Install all 3 operators (amq broker/argocd/otel) in the OLM suggested namespace (openshift-operators) from the operator hub.
oc get pods -n openshift-operators -l control-plane=controller-manager
NAME                                                         READY   STATUS    RESTARTS   AGE
amq-broker-controller-manager-674dcf8866-bp5qd               1/1     Running   0          77m
argocd-operator-controller-manager-5887d66dc6-cghxz          1/1     Running   0          6d4h
opentelemetry-operator-controller-manager-5b64497db6-hg9qj   2/2     Running   0          64m

Expected behavior
Have a more selective pod selector, for example use something like:
app.kubernetes.io/name=argocd-operator, control-plane=controller-manager

Additional information
ArgoCD Operator 0.8.0

@fuerer fuerer changed the title argocd-operator-controller-manager-service pod selector not unique argocd-operator-controller-manager-service pod selector not unique to argo Nov 28, 2023
@keskad
Copy link

keskad commented Dec 4, 2023

Hi, I have experienced exactly the same issue on OpenShift, using latest ArgoCD Operator v0.8.0. I think the issue started appearing after upgrade to this version.

How it looks in ArgoCD (when trying to synchronize kind: ArgoCD):

error when retrieving current configuration of: Resource: "argoproj.io/v1alpha1, Resource=argocds", GroupVersionKind: "argoproj.io/v1alpha1, Kind=ArgoCD" Name: "xxxx", Namespace: "xxxx" from server for: "xyz": conversion webhook for argoproj.io/v1beta1, Kind=ArgoCD failed: Post "[https://argocd-operator-controller-manager-service.xxx.svc:443/convert?timeout=30s](https://argocd-operator-controller-manager-service.xxx.svc/convert?timeout=30s)": dial tcp xxx.xxx.y.zzz:9443: connect: connection refused

When I do the oc get pods -n openshift-operators -l control-plane=controller-manager I get very similar result, there are pods of other operators visible.

kind: Service is having a label selector control-plane=controller-manager which is too generic.

@keskad
Copy link

keskad commented Dec 5, 2023

I'm not sure if I found the problematic place:
https://github.com/argoproj-labs/argocd-operator/blob/v0.8.0/deploy/olm-catalog/argocd-operator/0.8.0/argocd-operator.v0.8.0.clusterserviceversion.yaml#L1726

It seems that in v0.9.0 the issue is probably resolved:

So I guess that next upgrade to v0.9.0 will fix it and make manual workarounds not neccessary anymore.

@fuerer
Copy link
Author

fuerer commented Apr 2, 2024

As version 0.9.0 has been released which fixed this issue, we can close this case.

@fuerer fuerer closed this as completed Apr 2, 2024
@keskad
Copy link

keskad commented Apr 3, 2024

I see that v0.9.0 disappeared?

In meantime somebody made an upgrade via RedHat Operator Hub and it ended with:

install strategy failed: Deployment.apps "argocd-operator-controller-manager" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"control-plane":"argocd-operator"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

@Elyytscha
Copy link
Contributor

@svghadi can we reopen this? we have the same issue with 0.12.0

image

i think the issue is this

- label:
control-plane: controller-manager
name: argocd-operator-controller-manager
spec:
replicas: 1
selector:
matchLabels:
control-plane: controller-manager
im guessing right now olm creates the service for the operator from the clusterserviceversion which is the only place where i find those (missing) labels

the issue is simply

  selector:
    control-plane: controller-manager

is not guaranteed to be unique

@svghadi svghadi reopened this Sep 9, 2024
@svghadi
Copy link
Collaborator

svghadi commented Sep 9, 2024

It was updated to argocd-operator for one release and again changed back to controller-manager. Need to check with other maintainers to understand the reason.

@Elyytscha
Copy link
Contributor

i would maybe add more labels then just one, so this can't happen again.

our workaround for now is installing the argocd operator in ins own namespace via an own operatorgroup, where only this operator is installed

apiVersion: operators.coreos.com/v1
kind: OperatorGroup
metadata:
  name: argocd-operator
  namespace: argocd-operator
spec:
  upgradeStrategy: Default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants