-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make bundle
does not work on MacOS
#1564
Comments
Signed-off-by: appiepollo14 <[email protected]>
I've closed the PR as there is no generic approach to |
* Adds volumes and volumeMounts to argocd types * Adds e2e test * Updates generated files * Updates docs * Adds unit tests Fixes argoproj-labs#1564 using `make bundle` on MacOS Signed-off-by: appiepollo14 <[email protected]>
@appiepollo14 Could you try installing |
@anandf that off course solves the issue. However, this feels like an undocumented workaround to me. The core of this issue is the request to make the bundle target cross-platform compatible. So what was the purpose of replacing those labels and can't that be done in another fashion? |
Describe the bug
When running
make bundle
on MacOS, it exits premature with an error statement:sed: 1: "bundle/manifests/argocd ...": undefined label 'undle/manifests/argocd-operator-webhook-service_v1_service.yaml' make: *** [bundle] Error 1
This causes the generated bundle to not complete. Which led to a PR not passing CI, as the bundle is different than when it is generated on Linux in CI.
The rootcause is that there are some
sed
statements in the make statement which have unexpected behavior on MacOS exiting make.To Reproduce
Steps to reproduce the behavior:
use a MacOS system!
make bundle
Expected behavior
Execute
make bundle
without an error caused bysed
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Solution / explanation of the difference between sed on systems is posted here: https://stackoverflow.com/questions/12272065/sed-undefined-label-on-macos
The text was updated successfully, but these errors were encountered: