diff --git a/config/crd/bases/promoter.argoproj.io_promotionstrategies.yaml b/config/crd/bases/promoter.argoproj.io_promotionstrategies.yaml index 1ad5d91..0401fba 100644 --- a/config/crd/bases/promoter.argoproj.io_promotionstrategies.yaml +++ b/config/crd/bases/promoter.argoproj.io_promotionstrategies.yaml @@ -164,6 +164,8 @@ spec: sha: type: string time: + description: 'FIXME: docs, is this commit time, first-became-healthy + time, most-recently-observed-healthy time, etc?' format: date-time type: string required: diff --git a/internal/scms/github/git_operations.go b/internal/scms/github/git_operations.go index b87bbb6..cf2ed47 100644 --- a/internal/scms/github/git_operations.go +++ b/internal/scms/github/git_operations.go @@ -45,9 +45,9 @@ func NewGithubGitAuthenticationProvider(scmProvider *v1alpha1.ScmProvider, secre func (gh GitAuthenticationProvider) GetGitHttpsRepoUrl(gitRepository v1alpha1.GitRepository) string { if gh.scmProvider.Spec.GitHub != nil && gh.scmProvider.Spec.GitHub.Domain == "" { - return fmt.Sprintf("https://git@github.com/%s/%s.git", gitRepository.Spec.Owner, gitRepository.Name) + return fmt.Sprintf("https://git@github.com/%s/%s.git", gitRepository.Spec.Owner, gitRepository.Spec.Name) } - return fmt.Sprintf("https://git@%s/%s/%s.git", gh.scmProvider.Spec.GitHub.Domain, gitRepository.Spec.Owner, gitRepository.Name) + return fmt.Sprintf("https://git@%s/%s/%s.git", gh.scmProvider.Spec.GitHub.Domain, gitRepository.Spec.Owner, gitRepository.Spec.Name) } func (gh GitAuthenticationProvider) GetToken(ctx context.Context) (string, error) {