Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeTransferPolicy controller should merge autonomously #73

Open
crenshaw-dev opened this issue Oct 22, 2024 · 0 comments
Open

ChangeTransferPolicy controller should merge autonomously #73

crenshaw-dev opened this issue Oct 22, 2024 · 0 comments

Comments

@crenshaw-dev
Copy link
Contributor

Right now the PromotionStrategy controller enforces its ordering rules by directly managing the PullRequest under a given ChangeTransferPolicy.

Instead, the PromotionStrategy should inject something like an previous-environment check in environments besides the first one, and the ChangeTransferPolicy controller should independently merge PRs once the checks pass.

This frees the PromotionStrategy controller of having to manage promotion logic directly and allows it to delegate that work via the existing mechanism. It also allows us to replace the vanity "copied statuses" with an actually-used status to gate promotion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant