en/latest/walk-through/dag/

[giscus[bot]]

en/latest/walk-through/dag/

https://hera-workflows.readthedocs.io/en/latest/walk-through/dag/

[nambrosini17]

Thanks for the page, really useful. Just once piece of constructive feedback. Make more emphasis on the fact that "Dependencies can be described over multiple statements" starts a new example independent of the previous one. I spent some time thinking it was wrong until i figure out it was just another example of dependency between tasks

[flaviuvadan]

Thank you for the feedback @nambrosini17! Concretely, you're suggesting that we can do something like

a = foo(...)
b = bar(...)
a >> b

c = bee(...)
d = gee(...)
b >> c
b >> d

That's how I understood your suggestion of Dependencies can be described over multiple statements

[nambrosini17]

That's not exactly what i meant. Let me share a screenshot of what i mean.

Due to screen size (and perhaps a lack of emphasis) it isn't obvious that after the diagram we're presenting a new example when listing the bullets, and not referring to the diamond diagram above.

If you scroll down the new diagram is visible so my suggestion would be to rephrase

Dependencies can be described over multiple statements

To something like

To give another example, dependencies can be described over multiple statements

Or something like that. English is not my native language so perhaps you can rephrase but i believe some formatting would help understand it's a new example, not the same one as before

[flaviuvadan]

Got it, see #824

[elliotgunton]

Rereading the feedback, we missed in #824 the idea that the next example isn't introduced as a different dag. Will make a one liner to the doc.

[flaviuvadan]

Closing as #824 addresses this. Please feel free to reopen if needed!