Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments do not build correctly when using a dict #1169

Open
3 of 6 tasks
elliotgunton opened this issue Aug 21, 2024 · 0 comments
Open
3 of 6 tasks

Arguments do not build correctly when using a dict #1169

elliotgunton opened this issue Aug 21, 2024 · 0 comments
Labels
type:bug A general bug

Comments

@elliotgunton
Copy link
Collaborator

Pre-bug-report checklist

1. This bug can be reproduced using pure Argo YAML

If yes, it is more likely to be an Argo bug unrelated to Hera. Please double check before submitting an issue to Hera.

2. This bug occurs in Hera when...

  • exporting to YAML
  • submitting to Argo
  • running on Argo with the Hera runner
  • other:

Bug report

Describe the bug
A clear and concise description of what the bug is:

TODO - basically using w.arguments = {"param_name": "value"} before doing w.create() doesn't get the argument correctly because we don't check if self.arguments is itself a dict here

for arg in self.arguments:

Error log if applicable:

error: something broke!

To Reproduce
Full Hera code to reproduce the bug:

from hera.workflows import Workflow

with Workflow(name="my-workflow") as w:
    # Add your code here

Expected behavior
A clear and concise description of what you expected to happen:

Environment

  • Hera Version: 5.X.X
  • Python Version: 3.X.X
  • Argo Version: 3.X.X

Additional context
Add any other context about the problem here.

@elliotgunton elliotgunton added the type:bug A general bug label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant