Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Gateway API example that is userd by Linkerd #80

Closed
AlonGluz opened this issue Sep 16, 2024 · 5 comments
Closed

Missing Gateway API example that is userd by Linkerd #80

AlonGluz opened this issue Sep 16, 2024 · 5 comments
Assignees
@AlonGluz
Labels
documentation Improvements or additions to documentation

Comments

@AlonGluz
Copy link
Contributor

I'll be happy to contribute if this is ok with you
@kostis-codefresh
Copy link
Collaborator

Yes please!

You can add it here https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/tree/main/examples

And also update the documentation here https://rollouts-plugin-trafficrouter-gatewayapi.readthedocs.io/en/latest/provider-status/

Thank you in advance

@Philipp-Plotnikov Philipp-Plotnikov added the documentation Improvements or additions to documentation label Sep 16, 2024
@AlonGluz
Copy link
Contributor Author

@kostis-codefresh On it, are there any rules I should be aware of?

@kostis-codefresh
Copy link
Collaborator

  • Try to make it similar with the other examples
  • Explain all the prerequisites needed for the setup
  • Make it clear which version of LinkerD you are using and which version of the Gateway API CRDs
  • Ideally it should be simple to replicate (use local cluster, an easy to find version of Linkerd, simple Argo Rollouts example) etc.

@AlonGluz
Copy link
Contributor Author

@kostis-codefresh #81

@kostis-codefresh
Copy link
Collaborator

#81 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlonGluz AlonGluz

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlonGluz @kostis-codefresh @Philipp-Plotnikov