Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undo action for the argo rollouts custom resource actions #19014

Open
skashrafbasha opened this issue Jul 10, 2024 · 1 comment
Open

Add undo action for the argo rollouts custom resource actions #19014

skashrafbasha opened this issue Jul 10, 2024 · 1 comment
Labels
component:actions Issues related to resource actions. enhancement New feature or request type:enhancement

Comments

@skashrafbasha
Copy link

skashrafbasha commented Jul 10, 2024

Summary

Add undo action for the argo rollouts custom resource actions

Motivation

This will be used to enable rollback button in rollout-extension to fix this issue

Proposal

Add undo action for the argo rollouts custom resource actions

  • This is dependent on the solution implemented for this proposal in argo-rollouts here
  • There is no built-in action to undo a particular revision and needs to be added as per the resource_actions docs here
  • A new undo action is required, which modifies the rollout resource with status.undo.revision with the rollback revision number.
  • Upon setting the rollout status.undo.revision, the rollout controller reconciliation will act as per the undo action and remove the status.undo.revision.
@jeanmorais
Copy link

+1 waiting for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:actions Issues related to resource actions. enhancement New feature or request type:enhancement
Projects
None yet
Development

No branches or pull requests

3 participants