Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification] Read webhook credentialsfor notification controller form the secret instead of configmap #20651

Open
ajinkyak423 opened this issue Nov 4, 2024 · 1 comment
Labels
component:notifications Related to notifications subsystem enhancement New feature or request

Comments

@ajinkyak423
Copy link
Contributor

Summary

Currently its a requirement of notification controller to store the webhook credentials like url Authdata etc in configmap kind. This is not very secure way to store this sensitive information. Instead we can use secret kind from where controller can read these details.

Document reference: https://argo-cd.readthedocs.io/en/stable/operator-manual/notifications/services/webhook/#send-slack

What change you think needs making.

Motivation

Please give examples of your use case, e.g. when would you use this.
While using webhook for sending notification like in the case of slack, the credentials are required to be stored in configmap kind which is not an secure option while pushing the code to the platforms like GitHub. Instead we can use secret kind from where controller can read these details.

Proposal

How do you think this should be implemented?
Use secret kind for storing the webhook credentials from where the controller can read these details.

@ajinkyak423 ajinkyak423 added the enhancement New feature or request label Nov 4, 2024
@ajinkyak423 ajinkyak423 changed the title Read webhook credentialsfor notification controller form the secret instead of configmap [Notification] Read webhook credentialsfor notification controller form the secret instead of configmap Nov 4, 2024
@gdsoumya gdsoumya added the component:notifications Related to notifications subsystem label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:notifications Related to notifications subsystem enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants