Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyncWindow should allow to have multiple sync windows which has same kind,schedule,duration #20712

Open
3 tasks done
keyolk opened this issue Nov 8, 2024 · 0 comments
Open
3 tasks done
Labels
bug Something isn't working

Comments

@keyolk
Copy link

keyolk commented Nov 8, 2024

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

Currently, it does not allow having multiple sync windows which have same kind+schedule+duration combination
Let's say I want to have sync windows like the below

[
  {
    "kind": "allow",
    "schedule": "0 0 * * *",
    "duration": "6h",
    "applications": [
      "two*"
    ],
    "timeZone": "Asia/Seoul"
  },
  {
    "kind": "allow",
    "schedule": "0 0 * * *",
    "duration": "9h",
    "applications": [
      "one*"
    ],
    "timeZone": "Asia/Seoul"
  },
...

It would stuck at project validation step at
https://github.com/argoproj/argo-cd/blob/master/pkg/apis/application/v1alpha1/app_project_types.go#L261

We can mitigate this by just splits it by minutes, but hope it been resolved to make it simple to manage.

To Reproduce

Just create multiple sync windows having the same kind+schedule+duration

Expected behavior

Allow to have multiple time duplicated sync windows

Version

argocd: v2.11.1+9f40df0
  BuildDate: 2024-05-21T22:43:41Z
  GitCommit: 9f40df0c29eca7e45a73f802f033dfd1ed0068e3
  GitTreeState: clean
  GoVersion: go1.22.3
  Compiler: gc
  Platform: darwin/amd64
argocd-server: v2.11.5+c4b283c
  BuildDate: 2024-07-15T17:39:54Z
  GitCommit: c4b283ce0c092aeda00c78ae7b3b2d3b28e7feec
  GitTreeState: clean
  GoVersion: go1.21.10
  Compiler: gc
  Platform: linux/arm64
  Kustomize Version: v5.2.1 2023-10-19T20:13:51Z
  Helm Version: v3.14.4+g81c902a
  Kubectl Version: v0.26.11
  Jsonnet Version: v0.20.0
@keyolk keyolk added the bug Something isn't working label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant