Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing on annotations to resources #3200

Open
panicboat opened this issue Jul 8, 2024 · 3 comments
Open

Passing on annotations to resources #3200

panicboat opened this issue Jul 8, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@panicboat
Copy link

Is your feature request related to a problem? Please describe.
We are having trouble monitoring because we cannot link user metrics to datadog.

Describe the solution you'd like
I would like to be able to pass on annotations specified for EventBus, EventSource and Sensor to Deployment and StatefulSet.
https://docs.datadoghq.com/containers/kubernetes/integrations/?tab=annotations

Describe alternatives you've considered
None

Additional context
For example, in EventBus (JetStream), annotations are specified as follows, but I think I can take over by merging EventBus annotations.

Annotations: map[string]string{
common.AnnotationResourceSpecHash: hash,
},


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@panicboat panicboat added the enhancement New feature or request label Jul 8, 2024
@omerap12
Copy link
Contributor

I'll help with that :)

@omerap12
Copy link
Contributor

Created a PR, if it looks good I will implement this on more resources.

@francescsanjuanmrf
Copy link

These annotations are also required for some Istio configurations.
https://istio.io/latest/docs/reference/config/annotations/
It would be great if they were implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants