Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventSource/WebHook - Service annotations #3242

Open
pburgisser opened this issue Aug 16, 2024 · 2 comments
Open

EventSource/WebHook - Service annotations #3242

pburgisser opened this issue Aug 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@pburgisser
Copy link

Is your feature request related to a problem? Please describe.
On GKE with Application LoadBalancer, when exposing a webhook a HTTP healthcheck is automatically created and points to the service port (for example 12000) on path /. The checks fail as the probe is on /health. We can override the path to user by creating a backendconfig. However, we need to reference that backendconfig in the service's annotations.

Documentation of the EventSource shows that we can't inject custom annotations

Describe the solution you'd like
In the service's part of the EventSource, we should be able to add annotations.

Describe alternatives you've considered
Creating (and "duplicating") a service that points to the webhook pod with the annotations


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@pburgisser pburgisser added the enhancement New feature or request label Aug 16, 2024
@pburgisser pburgisser changed the title EventSource - Service annotations EventSource/WebHook - Service annotations Aug 16, 2024
@MenD32
Copy link
Contributor

MenD32 commented Aug 23, 2024

I have also experienced this issue, a quick fix is to define the BackendConfig in the GCP console but it'd be very nice to have it work out-of-the-box in k8s

@MenD32
Copy link
Contributor

MenD32 commented Aug 24, 2024

i opened a PR since this change can be pretty easy to implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants