Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the interactive object dependency for Containers and Revision Widgets #3713

Open
skashrafbasha opened this issue Jul 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@skashrafbasha
Copy link

Summary

Split the interactive object dependency for Containers and Revision Widgets here

Use Cases

This will be used to enable rollback button in rollout-extension to fix argoproj-labs/rollout-extension#44

  • Split the interactive object dependency for Containers and Revision Widgets here
  • The same interactive object is tightly coupled with both RevisionWidget and ContainersWidget (to render Containers and initContainers).
  • If we pass an interactive object for undo functionality, it will also enable changing the images in the ContainersWidget.
  • Split with additional flags in the interactive object for both Revision and Containers widgets and make it backward compatible by making those flags to default true.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant