Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after removing a Rollout the referenced deployment from "workloadRef" keeps the entry "replicas: 0" if "scaleDown" is used #3855

Open
Sven1410 opened this issue Sep 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Sven1410
Copy link

If a rollout resource is removed from the cluster the referenced deployment from "workloadRef" keeps the entry "replicas: 0" (if "scaleDown" is used). It will never scale up. This causes a service interruption.

use Case:

we use "scaleDown" in our rollout spec:

workloadRef:
  apiVersion: apps/v1
  kind: Deployment
  name: {{ .Release.Name }}
  scaleDown: onsuccess

we use this in a helm chart which allows to switch off the use of argo rollouts (and switch back to use the deployment directly). If we switch it off - the rollout resource is removed (by argo-cd). And the deployment stays with "replicas: 0" forever.
We also use a hpa --> it ignores that state with "scaling is disabled since the replica count of the target is zero"

It would be great if the argo-rollouts controller can detect this and remove the "Replicas: 0" if a rollout is removed.

version of argo rollouts: 1.7.2


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@Sven1410 Sven1410 added the bug Something isn't working label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant