Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy from logs using Ctrl-C doesn't work on Linux & Windows #557

Closed
Adrien-D opened this issue May 29, 2024 · 0 comments · Fixed by #558
Closed

Copy from logs using Ctrl-C doesn't work on Linux & Windows #557

Adrien-D opened this issue May 29, 2024 · 0 comments · Fixed by #558
Labels
type/bug Something isn't working

Comments

@Adrien-D
Copy link
Member

Adrien-D commented May 29, 2024 •
edited
Loading

All the details for this issue are here argoproj/argo-workflows#12947

I dug into this issue ans it's due to the Terminal from xterm in LogsViewer component that catches Keyboard events. This bug is still in an open state on xterm repo, and seems to be a desired behavior, so no real need to update it.

As a workaround I'll implement something inspired from xtermjs/xterm.js#2478 (comment)
This was referenced May 29, 2024
Merged
Closed
@agilgur5 agilgur5 changed the title Copy from workflow logs using Ctrl-C doesn't work Copy from logs using Ctrl-C doesn't work on Linux & Windows May 29, 2024
@agilgur5 agilgur5 added the type/bug Something isn't working label May 29, 2024
agilgur5 added a commit that referenced this issue Jun 6, 2024
@Adrien-D @agilgur5
fix: copy logs text on Linux & Windows. Fixes #557 (#558)
0bce165 
fix: copy logs text on windows

Co-authored-by: Anton Gilgur <[email protected]>
Signed-off-by: Adrien Delannoy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: copy logs text on Linux & Windows. Fixes #557 Adrien-D/argo-ui
2 participants
@Adrien-D @agilgur5