chore: enable assignOp rule from go-critic

mmorel-35 · mmorel-35 · commit bd0dc622d71e · 2025-08-18T08:41:07.000+02:00
Signed-off-by: Matthieu MOREL &lt;matthieu.morel35@gmail.com&gt;
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -18,7 +18,6 @@ linters:
     gocritic:
       disabled-checks:
         - appendAssign
-        - assignOp
         - badRegexp
         - builtinShadow
         - commentedOutCode
diff --git a/pkg/diff/diff.go b/pkg/diff/diff.go
@@ -1106,7 +1106,7 @@ func hide(target, live, liveLastAppliedAnnotation *unstructured.Unstructured, ke
 			replacement, ok := valToReplacement[val]
 			if !ok {
 				replacement = nextReplacement
-				nextReplacement = nextReplacement + "++++"
+				nextReplacement += "++++"
 				valToReplacement[val] = replacement
 			}
 			data[k] = replacement
diff --git a/pkg/sync/sync_context.go b/pkg/sync/sync_context.go
@@ -939,7 +939,7 @@ func (sc *syncContext) getSyncTasks() (_ syncTasks, successful bool) {
 			}
 		}
 	}
-	syncPhaseLastWave = syncPhaseLastWave + 1
+	syncPhaseLastWave++
 
 	for _, task := range tasks {
 		if task.isPrune() &&

Original file line number	Diff line number	Diff line change
`@@ -1106,7 +1106,7 @@ func hide(target, live, liveLastAppliedAnnotation *unstructured.Unstructured, ke`
`1106`	`1106`	`replacement, ok := valToReplacement[val]`
`1107`	`1107`	`if !ok {`
`1108`	`1108`	`replacement = nextReplacement`
`1109`		`- nextReplacement = nextReplacement + "++++"`
	`1109`	`+ nextReplacement += "++++"`
`1110`	`1110`	`valToReplacement[val] = replacement`
`1111`	`1111`	`}`
`1112`	`1112`	`data[k] = replacement`
Original file line number	Diff line number	Diff line change
`@@ -939,7 +939,7 @@ func (sc *syncContext) getSyncTasks() (_ syncTasks, successful bool) {`
`939`	`939`	`}`
`940`	`940`	`}`
`941`	`941`	`}`
`942`		`- syncPhaseLastWave = syncPhaseLastWave + 1`
	`942`	`+ syncPhaseLastWave++`
`943`	`943`
`944`	`944`	`for _, task := range tasks {`
`945`	`945`	`if task.isPrune() &&`