bug: old api-key version for New-Relic service

[rozdestvenskiy]

Now new-relic service uses old api key: https://github.com/argoproj/notifications-engine/blob/master/pkg/services/newrelic.go (line 153) req.Header.Set("Api-Key", s.opts.ApiKey)

According to documentation it should be req.Header.Set("X-Api-Key", s.opts.ApiKey) (https://docs.newrelic.com/docs/apis/rest-api-v2/get-started/introduction-new-relic-rest-api-v2/)

Now newrelic module doesn't create deployment markers. Same request with curl works (because of type of header).

[rozdestvenskiy]

Created PR
#181

[lancehudson]

Do we know if this has been included in a recent ArgoCD release?

[rozdestvenskiy]

@lancehudson looks like not. I'm still getting the same error:
time="2023-08-17T08:55:08Z" level=error msg="Failed to notify recipient {newrelic APP_ID} defined in resource argocd/my-app: Post \"api.newrelic.com/v2/applications/APP_ID/deployments.json\": unsupported protocol scheme \"\"" resource=argocd/my-app