Feat(eos_designs): Add support for Port-Channel for Direct HA

[gmuloc]

Change Summary

Add support for port-channel for Direct HA

Component(s) name

arista.avd.eos_designs

Proposed changes

• By default direct HA interfaces are grouped in a port-channel (even if there is only one direct interface)
• port-channel ID is computed the same as for MLAG
• Using a port-channel can be disabled when there is only one direct interface
• Fix flow tracking for direct HA
• No port-channel support for HA via uplinks
• Adjust router path-selection config when port-channel is used

How to test

negative unit tests

• test that cannot configure multiple direct HA interfaces and disable port-channel this was removed post refactor

positive unit tests

• direct HA, one link, no port-channel
• change port-channel ID (can be grouped with another test)
• direct HA multiple links
• Verify flow tracking (there was an issue)

Checklist

User Checklist

• tests
• update how-to
  • add entry in porting guide as Port-Channel on DPS requires a certain version of EOS so we want people to know how to downgrade
  • update wrong images in how-to doc (wrong route-map comment for LAN/HA)
• tested scenarii on live devices
  • two links in port-channel for direct HA ✅
  • one link in port-channel for direct HA ✅
  • one link without port-channel for direct HA ✅

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4482
# Activate the virtual environment
source test-avd-pr-4482/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@wan-lan-ha-port-channel#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,wan-lan-ha-port-channel --force
# Optional: Install AVD examples
cd test-avd-pr-4482
ansible-playbook arista.avd.install_examples

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[sonarcloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud