Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs)!: Change L3 P2P descriptions for uplinks and p2p_links #4520

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Sep 26, 2024

Change Summary

Change L3 P2P descriptions for uplinks and p2p_links

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Adding new default descriptions for MLAG SVIs and VLANs
  • Add templating support for all
  • Add keys with default templates:
    • default_underlay_p2p_ethernet_description
    • default_underlay_p2p_port_channel_description
  • Updated porting guide

How to test

  • Update molecule scenarios and examples
  • Verified no changes for scenarios with custom description logic in unit tests

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4520
# Activate the virtual environment
source test-avd-pr-4520/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/l3-p2p-descriptions#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/l3-p2p-descriptions --force
# Optional: Install AVD examples
cd test-avd-pr-4520
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Sep 26, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Sep 26, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/l3-p2p-descriptions branch from 73d1388 to e5fc6cb Compare September 26, 2024 13:41
@github-actions github-actions bot removed the state: conflict PR with conflict label Sep 26, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/l3-p2p-descriptions branch from e5fc6cb to b534e2c Compare September 27, 2024 11:08
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review September 27, 2024 11:08
Copy link

sonarcloud bot commented Sep 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants