Using the name "binary" for a program is confusing when there is a file format in IDA named "binary file"

[Harding-Stardust]

When checking if the file is a DLL/SO or a program, the name "binary" is used and can easily be confused with a file type that is pure data (such as shellcode)

ida_loader.get_file_type_name() # returns "Binary file" on shellcode
The code do not make a difference on "binary file" and "runnable program"

if ida_idaapi.get_inf_structure().is_dll():
    return "Shared object"
elif ida_loader.get_file_type_name() == "Binary file":
    return "Binary"
else: # This might not be a good idea since we might have somethine else that DLL/Binary/Program that can be returned?
    return "Program"

https://github.com/arizvisa/ida-minsc/blob/af07f167a0992aed3f3a2a1670593880baa57820/base/database.py#L79C16-L79C16

[arizvisa]

That code that you've linked isn't the same as what you've pasted?

You linked line #79, but lines 72-94 looks like:

ida-minsc/base/database.py

Lines 72 to 94 in af07f16

	def __init_info_structure__(cls, idp_modname):
	information = idaapi.get_inf_structure()
	if information:
	logging.debug(u"{:s}.__init_info_structure__({!s}) : Successfully fetched and cached information structure for database.".format('.'.join([__name__, cls.__name__]), utils.string.escape(idp_modname, '"')))
	# Display summary of the database and what it's used for.
	bits = "{:d}-bit".format(64 if information.is_64bit() else 32 if information.is_32bit() else 16)
	format = 'library' if information.lflags & idaapi.LFLG_IS_DLL else 'binary'
	if idaapi.__version__ < 7.0:
	byteorder = "{:s}-endian".format('big' if idaapi.cvar.inf.mf else 'little')
	else:
	byteorder = "{:s}-endian".format('big' if information.lflags & idaapi.LFLG_MSF else 'little')
	if idaapi.__version__ >= 7.0:
	mode = ' kernelspace' if information.lflags & idaapi.LFLG_KERNMODE else ' userspace'
	else:
	mode = ''
	logging.warning("Initialized {tag!s} database v{version:d} for {bits:s} {byteorder:s}{mode:s} {format:s}.".format('.'.join([information.__class__.__module__, information.__class__.__name__]), tag=information.tag, bits=bits, byteorder=byteorder, mode=mode, format=format, version=information.version))
	else:
	logging.fatal(u"{:s}.__init_info_structure__({!s}) : Unknown error while trying to get information structure for database.".format('.'.join([__name__, cls.__name__]), utils.string.escape(idp_modname, '"')))
	cls.info = information

But, to clarify. This is just aesthetic and is only to display some status of the inf structure once the processor module has been determined. Other than the function assigning an instance of the inf structure, it is unable to be interacted with by the user.

This is is why it's only fetching attributes from the structure and not attempting to do anything with real purpose. If the inf structure cannot return these attributes, it should produce an exception along with a bug report.

[Harding-Stardust]

Line 79 is the line I think is wrong (or rather wanted to be changed into the code I proposed)

format = 'library' if information.lflags & idaapi.LFLG_IS_DLL else 'binary'

should be

format = "Unknown"
if ida_idaapi.get_inf_structure().is_dll():
    format = "Shared object"
elif ida_loader.get_file_type_name() == "Binary file":
    format = "Binary"
else: # This might not be a good idea since we might have somethine else that DLL/Binary/Program that can be returned?
    format = "Program"

[arizvisa]

So, the reason why I'm not sure about this is because this hook is not related at all to the loader whatsoever. It's actually just acting on information about the database and not what loaders/processors write into the database. The logging it emits is mostly for distinguishing what "type" of a database was created by the disassembler and is only a courtesy when running multiple instances of the disassembler in parallel.

The other thing is that doing an explicit comparison for the file type name would mean that I would need to add checks for every file type name to ensure it's formatted properly rather than just distinguish this as a boolean. If you have a better name for "not a shared object", I'd consider that instead...But, one thing to keep in mind is that not everything is a "Program", it could be firmware, it could be random bytes, etc. But it always can be considered binary data.

Another thing is that I'm unsure about the casing because of how it gets plugged into its sentence that gets pasted when the hook executes. Despite the logger suckage (I am just one man after all and can't fix _everything_), it is a proper sentence that doesn't attempt to detract you from its intent.

Loading processor module /home/look-at-me-mom-ima-user/idapro-8.3/procs/pc.so for metapc...Initializing processor module metapc...WARNING:root:Initialized IDA database v830 for 16-bit little-endian userspace binary.

[arizvisa]

Converting to a discussion under "Ideas".