Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide promisified api out-of-the-box #243

Open
kibertoad opened this issue Jun 2, 2022 · 4 comments
Open

Provide promisified api out-of-the-box #243

kibertoad opened this issue Jun 2, 2022 · 4 comments
Assignees

Comments

@kibertoad
Copy link
Contributor

Current behavior

Users have to promisify node-freshdesk-api

Expected behavior

Promise-based API is available out-of-the-box

More details

No additional libraries are needed for this, Node has native solution: https://nodejs.org/api/util.html#utilpromisifyoriginal

@arjunkomath arjunkomath self-assigned this Jun 2, 2022
@arjunkomath
Copy link
Owner

I can look into this.

@kibertoad
Copy link
Contributor Author

I can do this together with undici conversion then

@arjunkomath
Copy link
Owner

@kibertoad Thanks, if the PR gets too big I'd prefer if we break them into two separate PRs.

@kibertoad
Copy link
Contributor Author

kibertoad commented Feb 16, 2024

@arjunkomath Effort required for this was too big, I don't think I can realistically handle that in the end, unfortunately :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants