Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random-mac only with systemd-networkd (minimal images) #6783

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jun 22, 2024

Description

Closing #6773

Jira reference number AR-2382

How Has This Been Tested?

  • When netplan random mac defs are present, device (Odroid M1) does not get IP

Checklist:

  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik requested a review from a team as a code owner June 22, 2024 20:11
@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Jun 22, 2024
@ColorfulRhino
Copy link
Collaborator

What do you mean by "setting mac via netplan does not apply to network manager"? Where is the issue? Does it not generate the correct config for NM? We may try with netplan generate

I do understand "When netplan random mac defs are present, device (Odroid M1) does not get IP" on the other hand.

@igorpecovnik
Copy link
Member Author

igorpecovnik commented Jun 23, 2024

What do you mean by "setting mac via netplan does not apply to network manager"?

According to my research, if we would like to have different MAC we need to solve it via NM internal commands. Common way doesn't work. On the other hand, this is legacy feature and can probably be just dropped.

Does it not generate the correct config for NM? We may try with netplan generate

It seems. netplan generate does nothing.

@igorpecovnik igorpecovnik changed the title Add NETWORKING_TYPE info to the image and use random-mac only with systemd-networkd (minimal images) Use random-mac only with systemd-networkd (minimal images) Jun 23, 2024
@igorpecovnik igorpecovnik added 08 Milestone: Third quarter release Needs review Seeking for review Bugfix Pull request is fixing a bug labels Jun 23, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge Patches Patches related to kernel, U-Boot, ... and removed Needs review Seeking for review labels Jun 24, 2024
@igorpecovnik igorpecovnik merged commit d317e54 into main Jun 24, 2024
@igorpecovnik igorpecovnik deleted the AR-2382 branch June 24, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Bugfix Pull request is fixing a bug Framework Framework components Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

3 participants