Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(partially) Revert "python: Move python3-setuptools and python3-pyelftools to requirements.txt" #6818

Closed
wants to merge 1 commit into from
Closed

(partially) Revert "python: Move python3-setuptools and python3-pyelftools to requirements.txt" #6818

wants to merge 1 commit into from

Conversation

rpardini
Copy link
Member

(partially) Revert "python: Move python3-setuptools and python3-pyelftools to requirements.txt"

@rpardini
(partially) Revert "python: Move python3-setuptools and `python3-py…
3fbe504 
…elftools` to requirements.txt"

- "Fixes" armbian#6799

This (partially) reverts commit 04f619d
@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Jun 28, 2024
@rpardini rpardini mentioned this pull request Jun 28, 2024
Merged
6 tasks
@rpardini rpardini requested a review from ColorfulRhino June 28, 2024 09:05
@rpardini rpardini marked this pull request as ready for review June 28, 2024 09:05
@rpardini rpardini requested a review from a team as a code owner June 28, 2024 09:05
@ColorfulRhino
Copy link
Collaborator

Copy-pasting comments from the linked PR:

u-boot's requiring elftools are not finding it. https://paste.next.armbian.com/busaleqife

Partially reverting this fixes it; I think some ENVs will need to be set for the u-boot-called Python to find the requirements.txt-installed dependencies.

@ColorfulRhino
Copy link
Collaborator

ColorfulRhino commented Jun 28, 2024 •
edited
Loading

@rpardini Please see and test #6819

@ColorfulRhino ColorfulRhino mentioned this pull request Jun 28, 2024
Merged
6 tasks
@ColorfulRhino
Copy link
Collaborator

The following remedy makes this PR obsolete: #6819

@rpardini rpardini closed this Jun 30, 2024
@rpardini
Copy link
Member Author

Closing in favor of #6819 -- thanks (again!) @ColorfulRhino

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joekhoobyar joekhoobyar joekhoobyar approved these changes

@ColorfulRhino ColorfulRhino Awaiting requested review from ColorfulRhino

Assignees
No one assigned
Labels
Framework Framework components size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpardini @ColorfulRhino @joekhoobyar