fix: resolve Sonar findings and security violations

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>

Author: arnabnandy7

.github/workflows/sonarcloud.yml

@@ -45,7 +45,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v7
+        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
         with:
           fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
 
@@ -56,7 +56,7 @@ jobs:
           cache: npm
 
       - name: Install dependencies
-        run: npm ci
+        run: npm ci --ignore-scripts
 
       - name: Run tests with coverage
         run: npm run test:coverage

src/components/theme-provider.tsx

@@ -2,7 +2,7 @@
 
 import { ThemeProvider as NextThemesProvider } from "next-themes";
 
-export function ThemeProvider({ children }: { children: React.ReactNode }) {
+export function ThemeProvider({ children }: Readonly<{ children: React.ReactNode }>) {
   return (
     <NextThemesProvider
       attribute="class"

src/features/issues/components/issue-card.tsx

@@ -11,7 +11,18 @@ import { Separator } from "@/components/ui/separator";
 import { compactNumber, relativeDate } from "@/features/issues/lib/format";
 import type { Issue } from "@/features/issues/types/search";
 
-export function IssueCard({ issue }: { issue: Issue }) {
+export function IssueCard({ issue }: Readonly<{ issue: Issue }>) {
+  let qualityBadgeClassName =
+    "bg-rose-500/10 text-rose-700 dark:text-rose-400 border-rose-500/20";
+
+  if (issue.qualityScore >= 70) {
+    qualityBadgeClassName =
+      "bg-emerald-500/10 text-emerald-700 dark:text-emerald-400 border-emerald-500/20";
+  } else if (issue.qualityScore >= 40) {
+    qualityBadgeClassName =
+      "bg-amber-500/10 text-amber-700 dark:text-amber-400 border-amber-500/20";
+  }
+
   return (
     <Card>
       <CardHeader className="gap-3">
@@ -32,19 +43,9 @@ export function IssueCard({ issue }: { issue: Issue }) {
                   : "Hacktoberfest label"}
               </Badge>
             ) : null}
-            {issue.qualityScore >= 70 ? (
-              <Badge className="bg-emerald-500/10 text-emerald-700 dark:text-emerald-400 border-emerald-500/20">
-                {issue.qualityScore} quality
-              </Badge>
-            ) : issue.qualityScore >= 40 ? (
-              <Badge className="bg-amber-500/10 text-amber-700 dark:text-amber-400 border-amber-500/20">
-                {issue.qualityScore} quality
-              </Badge>
-            ) : (
-              <Badge className="bg-rose-500/10 text-rose-700 dark:text-rose-400 border-rose-500/20">
-                {issue.qualityScore} quality
-              </Badge>
-            )}
+            <Badge className={qualityBadgeClassName}>
+              {issue.qualityScore} quality
+            </Badge>
             {issue.helpStatus === "open" && (
               <Badge className="bg-emerald-500/10 text-emerald-700 dark:text-emerald-400 border-emerald-500/20">
                 Needs Help

src/features/issues/components/metric.tsx

@@ -1,4 +1,4 @@
-export function Metric({ label, value }: { label: string; value: string }) {
+export function Metric({ label, value }: Readonly<{ label: string; value: string }>) {
   return (
     <div className="rounded-md border bg-background p-3">
       <div className="text-xs text-muted-foreground">{label}</div>

src/features/issues/server/github-search.ts

@@ -28,7 +28,7 @@ function normalize(value: string | null) {
 }
 
 function quoteSearchValue(value: string) {
-  return /[\s#+.]/.test(value) ? `"${value.replaceAll('"', '\\"')}"` : value;
+  return /[\s#+.]/.test(value) ? `"${value.replaceAll('"', String.raw`\"`)}"` : value;
 }
 
 function buildTechQualifier(tech: string) {

src/features/issues/types/search.ts

@@ -49,7 +49,7 @@ export type GitHubIssue = {
   created_at: string;
   repository_url: string;
   labels: GitHubLabel[];
-  assignee: unknown | null;
+  assignee: unknown;
   assignees?: unknown[];
 };
 

tests/features/issues/components/issue-finder.test.tsx

@@ -136,7 +136,7 @@ describe("IssueFinder", () => {
     render(<IssueFinder />);
     fireEvent.submit(screen.getByRole("button", { name: "Search" }).closest("form")!);
 
-    expect(await screen.findByText("Ranked issues")).toBeTruthy();
+    expect(await screen.findByRole("heading", { name: "Ranked issues" })).toBeTruthy();
     expect(screen.getByText("Issue 24")).toBeTruthy();
     fireEvent.click(screen.getByRole("button", { name: "Load More" }));
     expect(await screen.findByText("Issue 25")).toBeTruthy();