From 88b78a4591ddfb884d34fbeaa25e0b64f9e1f1a2 Mon Sep 17 00:00:00 2001 From: Arnab Nandy Date: Thu, 3 Sep 2026 20:56:15 +0530 Subject: [PATCH 1/2] refactor: reduce IssueFinder cognitive complexity Signed-off-by: Arnab Nandy --- .../issues/components/issue-finder.tsx | 332 ++++++++++-------- 1 file changed, 195 insertions(+), 137 deletions(-) diff --git a/src/features/issues/components/issue-finder.tsx b/src/features/issues/components/issue-finder.tsx index 5ec3473..ec51625 100644 --- a/src/features/issues/components/issue-finder.tsx +++ b/src/features/issues/components/issue-finder.tsx @@ -887,6 +887,180 @@ function IssueContentTabs({ ); } +function IssueFinderSidebar({ + tech, + savedSearchName, + savedSearches, + authenticated, + linkedEmail, + alertEmail, + digestEnabled, + digestStatus, + isDigestPending, + onTechChange, + onLabelChange, + onSavedSearchNameChange, + onSaveSearch, + onRunSavedSearch, + onDeleteSavedSearch, + onAlertEmailChange, + onDigestPreferenceChange, + onSaveAlertEmail, + onDigestTrigger, +}: Readonly<{ + tech: string; + savedSearchName: string; + savedSearches: SavedSearch[]; + authenticated: boolean; + linkedEmail?: string | null; + alertEmail: string; + digestEnabled: boolean; + digestStatus: string | null; + isDigestPending: boolean; + onTechChange: (value: string) => void; + onLabelChange: (value: string) => void; + onSavedSearchNameChange: (value: string) => void; + onSaveSearch: () => void; + onRunSavedSearch: (savedSearch: SavedSearch) => void; + onDeleteSavedSearch: (id: string) => void; + onAlertEmailChange: (value: string) => void; + onDigestPreferenceChange: () => void; + onSaveAlertEmail: () => void; + onDigestTrigger: () => void; +}>) { + return ( + + ); +} + export function IssueFinder() { const { data: session, isPending: isSessionPending } = authClient.useSession(); @@ -1745,143 +1919,27 @@ export function IssueFinder() {
- + void handleDeleteSavedSearch(id)} + onAlertEmailChange={setAlertEmail} + onDigestPreferenceChange={() => void handleDigestPreference()} + onSaveAlertEmail={() => void handleAlertEmail()} + onDigestTrigger={() => void handleDigestTrigger()} + /> Date: Thu, 3 Sep 2026 21:04:22 +0530 Subject: [PATCH 2/2] fix: provide fallback admin email Signed-off-by: Arnab Nandy --- src/features/issues/components/issue-finder.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/features/issues/components/issue-finder.tsx b/src/features/issues/components/issue-finder.tsx index ec51625..28d21e5 100644 --- a/src/features/issues/components/issue-finder.tsx +++ b/src/features/issues/components/issue-finder.tsx @@ -1055,7 +1055,7 @@ function IssueFinderSidebar({ {authenticated ? : null} {authenticated ? ( - + ) : null} );