Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--keycap-text-hover property not being used #2526

Open
callumnewlands opened this issue Sep 22, 2024 · 0 comments
Open

--keycap-text-hover property not being used #2526

callumnewlands opened this issue Sep 22, 2024 · 0 comments
Labels
good first issue An issue that is a good introduction to the code base

Comments

@callumnewlands
Copy link

Description

The --keycap-text-hover does not result in any changes to the keyboard styling, the problem seems to be that the resulting local variable --_keycap-text-hover is not being used anywhere inside css/virtual-keyboard.less

In screenshot, the following values are being used:

--keycap-background: #c8e5fe;  // Light blue
--keycap-background-hover: #2d5a81;  // Dark blue
--keycap-text: #2d5a81;  // Dark blue
--keycap-text-hover: red;

image

As a related aside it would also be helpful to have a separate hover text colour variable for the keyboard-toolbar (currently there is only --keyboard-toolbar-text-active which controls both text of the currently selected toolbar tab and the hover state for the remaining tabs

In screenshot, the following values are being used:

--keyboard-background: #f4faff; // Lightest Blue
--keyboard-toolbar-text: #0058de;  // Blue
--keyboard-toolbar-text-active: red;  
--keyboard-toolbar-background-hover: #2d5a81;  // Dark blue

image

Steps to Reproduce

  1. Create a project with mathlive
  2. Attempt to customise the keycap hover colour by setting the --keycap-text-hover variable (I did this inside the CSS for the element set as window.mathVirtualKeyboard.container)

Actual Behavior

The keycap hover colour is taken from the --keycap-text var rather than the --keycap-text-hover var

Expected Behavior

The --keycap-text-hover var should affect the color of the keycap when it is hovered over

Environment

MathLive version Using mathlive v0.101.0 via npm
Operating System Windows 11 Home, 10.0 Build 22631
Browser Tested on Chrome, Firefox and Edge

@arnog arnog added the good first issue An issue that is a good introduction to the code base label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue that is a good introduction to the code base
Projects
None yet
Development

No branches or pull requests

2 participants