Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd behaviour of GBReweighter #59

Open
marthaisabelhilton opened this issue May 8, 2019 · 3 comments
Open

Odd behaviour of GBReweighter #59

marthaisabelhilton opened this issue May 8, 2019 · 3 comments
Labels

Comments

@marthaisabelhilton
Copy link

marthaisabelhilton commented May 8, 2019

I am trying to use GBReweighter and am getting odd behaviour of the weights as seen in the figures attached. My parameters are as follows:
reweighter = GBReweighter(n_estimators=40, learning_rate=0.1, max_depth=3, min_samples_leaf=1000, gb_args={'subsample': 0.4})
I have tried varying the parameters.
Do you know what might cause this behaviour?
Many thanks.
D02KSPiPiDD_2012_original.pdf
D02KSPiPiDD_2012_reweighted.pdf

@arogozhnikov
Copy link
Owner

arogozhnikov commented May 9, 2019

Can it be so that you have

  1. too few samples in MC and 1000 elements in the leaf are almost completely coming from real data?
  2. or there are regions in variable space where you have almost no MC? (I blindly guess that second is true, by looking at mu_P at lower values)

@marthaisabelhilton
Copy link
Author

Hello and thank you for your reply.

  1. I've checked and I have ~400000 events in the training sample for both MC and data. Is this ok?
  2. I actually made cuts on the data to make sure there is no regions without MC (after I made these plots)

@arogozhnikov
Copy link
Owner

  1. yes, that should be more than enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants