Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documenting behavior of normalization #83

Closed
goi42 opened this issue Oct 31, 2023 · 1 comment
Closed

Documenting behavior of normalization #83

goi42 opened this issue Oct 31, 2023 · 1 comment

Comments

@goi42
Copy link
Contributor

goi42 commented Oct 31, 2023

As described in #36, the weights produced by the reweighter are not normalized. As noted there, this is not incorrect, but it is undocumented. This is a critical feature that should appear in the documentation.
@arogozhnikov
Copy link
Owner

Hi Michael,
do you think this should be in tutorial or in reweighter docstrings?

Also, PR is welcome

@goi42 goi42 mentioned this issue Apr 3, 2024
Merged
@arogozhnikov arogozhnikov changed the title weight normalization not documented Documenting behavior of normalization Apr 3, 2024
@goi42 goi42 closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arogozhnikov @goi42