Skip to content

Update gh unit test workflow in AtoM to use ubuntu 24.04 #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anvit opened this issue Mar 4, 2025 · 3 comments · Fixed by #1956
Closed

Update gh unit test workflow in AtoM to use ubuntu 24.04 #1942

anvit opened this issue Mar 4, 2025 · 3 comments · Fixed by #1956
Assignees
@melaniekung
Milestone
2.9.1

Comments

@anvit
Copy link
Contributor

anvit commented Mar 4, 2025

GitHub is discontinuing Ubuntu 20.04, so we would need to update the unit test workflow to use 24.04.

PHP 8.x also breaks unit tests, since they're dependent on DebugPDO which has not been updated for PHP 8.0. The themselves tests also need updates since they contain a lot of PHP 8.x related deprecation warnings.
@anvit anvit mentioned this issue Mar 4, 2025
Merged
@erictapen
Copy link

I'm running into this problem as well, when trying to package AtoM for NixOS/Nixpkgs, which only has PHP 8. Having running unit tests always gives us some more assurance that the package is working as desired.

See my current efforts here: https://github.com/erictapen/nixos-atom

@melaniekung melaniekung linked a pull request Mar 13, 2025 that will close this issue
Update gh unit test workflow in AtoM to use ubuntu 24.04 #1956
Merged
@melaniekung melaniekung self-assigned this Mar 14, 2025
melaniekung added a commit that referenced this issue Mar 14, 2025
@melaniekung
Update GH unit tests to use Ubuntu 24.04. (#1942)
b2fe977 
- Replace DebugPDO with PropelPDO
- Fix deprecations/errors.
anvit pushed a commit that referenced this issue Apr 2, 2025
@melaniekung @anvit
Update GH unit tests to use Ubuntu 24.04. (#1942)
b9a6b8e 
- Replace DebugPDO with PropelPDO
- Fix deprecations/errors.
melaniekung added a commit that referenced this issue Apr 3, 2025
@melaniekung
Update GH unit tests to use Ubuntu 24.04. (#1942)
6615a26 
- Replace DebugPDO with PropelPDO
- Fix deprecations/errors.
melaniekung added a commit that referenced this issue Apr 3, 2025
@melaniekung
Update GH unit tests to use Ubuntu 24.04. (#1942)
cf9d543 
- Replace DebugPDO with PropelPDO
- Fix deprecations/errors.
@erictapen
Copy link

Great that this is closed. Is there any chance this could land in a minor release?

@anvit anvit added this to the 2.9.1 milestone Apr 7, 2025
@anvit
Copy link
Contributor Author

anvit commented Apr 7, 2025

@erictapen yes, we've just milestone'd this for the 2.9.1 minor release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melaniekung melaniekung

Labels
None yet
Projects
None yet
Milestone
2.9.1
Development

Successfully merging a pull request may close this issue.

Update gh unit test workflow in AtoM to use ubuntu 24.04 artefactual/atom
3 participants
@anvit @erictapen @melaniekung